pan3793 edited a comment on pull request #1319:
URL: https://github.com/apache/incubator-kyuubi/pull/1319#issuecomment-957583090
@zhouyifan279 is right, I'm going to revert this PR.
BTW, we also find other issues when reviewing the code, the method
`KyuubiSessionImpl#close` has a chance to be invoked more than one time, e.g.
client can send a `TCloseSessionReq` to Kyuubi server, meanwhile
`TimeoutChecker` may invoke `closeSession` in the background task thread, and
there may some other clean up logic will invoke `KyuubiSessionImpl#close`,
these may cause `CONN_FAIL` incorrect, we'd better add a `_closed` flag and put
the close logic into `synchronized { }` block to make sure the close logic only
execute once.
@jiaoqingbo, would you like to take this task?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
