zhouyifan279 commented on pull request #1319: URL: https://github.com/apache/incubator-kyuubi/pull/1319#issuecomment-957531300
A little late to comment. But I found some issue with this PR: If `KyuubiSessionImpl#openSession` failed in `KyuubiSessionImpl#open`, metric <CONN_OPEN, user> is not increased before we decrease it in `KyuubiSessionImpl#close`. And we will get a negative number if failures occurs more often than successes. Besides, I think this PR misunderstood the usage of metric <CONN_OPEN, user>. To my understanding, <CONN_OPEN, user> represents opening sessions. This convetion is also applied to engine scope CONN_OPEN and STATEMENT_OPEN. If we want a metric to represent succeeded sessions, I think we should add a new metric such as <CONN_SUCCEED, user>. cc @jiaoqingbo @pan3793 @yaooqinn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
