turboFei commented on a change in pull request #1377:
URL: https://github.com/apache/incubator-kyuubi/pull/1377#discussion_r749936608
##########
File path:
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/LaunchEngine.scala
##########
@@ -38,21 +42,19 @@ class LaunchEngine(session: KyuubiSessionImpl, override val
shouldRunAsync: Bool
}
override protected def afterRun(): Unit = {
+ if (shouldRunAsync) {
+ waitLaunchEngineComplete()
+ }
OperationLog.removeCurrentOperationLog()
Review comment:
I think if we remove this thread local directly, there is still remain
operation log to write after this thread local is removed.
is it safe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
