turboFei commented on a change in pull request #1377:
URL: https://github.com/apache/incubator-kyuubi/pull/1377#discussion_r749941836
##########
File path:
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/LaunchEngine.scala
##########
@@ -38,21 +42,19 @@ class LaunchEngine(session: KyuubiSessionImpl, override val
shouldRunAsync: Bool
}
override protected def afterRun(): Unit = {
+ if (shouldRunAsync) {
+ waitLaunchEngineComplete()
+ }
OperationLog.removeCurrentOperationLog()
Review comment:
for example, for async mode, the launch engine is still running in
backend.
But it might run `afterRun` before the launch engine operation finished.
Then if the launch engine failed eventually, it may do not recored the error
info into launch engine operation log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
