SteNicholas commented on a change in pull request #1938:
URL: https://github.com/apache/incubator-kyuubi/pull/1938#discussion_r811585307
##########
File path:
externals/kyuubi-flink-sql-engine/src/test/scala/org/apache/kyuubi/engine/flink/operation/FlinkOperationSuite.scala
##########
@@ -761,4 +761,18 @@ class FlinkOperationSuite extends WithFlinkSQLEngine with
HiveJDBCTestHelper {
.getStringVal.getValues.get(0) === "tmp.hello")
}
}
+
+ test("ensure result max rows") {
+ withSessionConf()(Map(KyuubiConf.ENGINE_FLINK_MAX_ROWS.key ->
"200"))(Map.empty) {
+ withJdbcStatement() { statement =>
+ statement.execute("create table tbl_src (a bigint) with ('connector' =
'datagen')")
+ val resultSet = statement.executeQuery(s"select a from tbl_src")
+ var rows = 0
+ while (resultSet.next()) {
+ rows += 1
+ }
+ assert(rows == 200)
Review comment:
```suggestion
assert(rows === 200)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
