link3280 commented on a change in pull request #1938:
URL: https://github.com/apache/incubator-kyuubi/pull/1938#discussion_r811603425
##########
File path:
externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/operation/ExecuteStatement.scala
##########
@@ -132,12 +133,16 @@ class ExecuteStatement(
while (loop) {
Thread.sleep(50) // slow the processing down
- val result = executor.snapshotResult(sessionId, resultId, 2)
+ val pageSize = Math.min(500, resultMaxRows)
+ val result = executor.snapshotResult(sessionId, resultId, pageSize)
result.getType match {
case TypedResult.ResultType.PAYLOAD =>
- rows.clear()
(1 to result.getPayload).foreach { page =>
- rows ++= executor.retrieveResultPage(resultId, page).asScala
+ if (rows.size < resultMaxRows) {
Review comment:
@SteNicholas Why pull another page if we already have the max number of
rows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
