wForget commented on a change in pull request #1966:
URL: https://github.com/apache/incubator-kyuubi/pull/1966#discussion_r812906847
##########
File path:
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala
##########
@@ -168,15 +169,23 @@ object SparkSQLEngine extends Logging {
def main(args: Array[String]): Unit = {
SignalRegister.registerLogger(logger)
- var spark: SparkSession = null
- try {
- spark = createSpark()
+ val submitTime = kyuubiConf.getOption(KYUUBI_ENGINE_SUBMIT_TIME_KEY) match
{
+ case Some(t) => t.toLong
+ case _ => 0L
+ }
+ val initTimeout = kyuubiConf.get(ENGINE_INIT_TIMEOUT)
+ if (System.currentTimeMillis() - submitTime > initTimeout) {
Review comment:
If we do nothing here, it will exit abnormally. Is that ok?
cc @yaooqinn @turboFei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
