wForget commented on a change in pull request #1966:
URL: https://github.com/apache/incubator-kyuubi/pull/1966#discussion_r813044775
##########
File path:
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala
##########
@@ -185,12 +194,13 @@ object SparkSQLEngine extends Logging {
case _ => error("Current SparkSQLEngine is not created.")
}
- }
- } catch {
- case t: Throwable => error(s"Failed to instantiate SparkSession:
${t.getMessage}", t)
- } finally {
- if (spark != null) {
- spark.stop()
+ }
+ } catch {
+ case t: Throwable => error(s"Failed to instantiate SparkSession:
${t.getMessage}", t)
+ } finally {
+ if (spark != null) {
+ spark.stop()
Review comment:
> The `spark` could be set to null.
Sorry, I don't understand what this needs to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
