yaooqinn commented on a change in pull request #1966:
URL: https://github.com/apache/incubator-kyuubi/pull/1966#discussion_r814420718
##########
File path:
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala
##########
@@ -70,16 +71,19 @@ case class SparkSQLEngine(spark: SparkSession) extends
Serverable("SparkSQLEngin
object SparkSQLEngine extends Logging {
+ val sparkConf: SparkConf = new SparkConf()
+
val kyuubiConf: KyuubiConf = KyuubiConf()
var currentEngine: Option[SparkSQLEngine] = None
private val user = currentUser
+ val appName = s"kyuubi_${user}_spark_${Instant.now}"
Review comment:
that‘s true. but the appName is not right here. for a complete pipeline,
the appName is generated by the Kyuubi server or set by users.
I suggest that we simply name the groupId in `createSpark` as "engine
initializing queries "
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
