Author: floriansemm
Date: Mon Mar 26 05:24:26 2012
New Revision: 1305227
URL: http://svn.apache.org/viewvc?rev=1305227&view=rev
Log:
don't fail silently. move check for firephp-lib to activeOptions method
Modified:
logging/log4php/trunk/src/main/php/appenders/LoggerAppenderFirephp.php
Modified: logging/log4php/trunk/src/main/php/appenders/LoggerAppenderFirephp.php
URL:
http://svn.apache.org/viewvc/logging/log4php/trunk/src/main/php/appenders/LoggerAppenderFirephp.php?rev=1305227&r1=1305226&r2=1305227&view=diff
==============================================================================
--- logging/log4php/trunk/src/main/php/appenders/LoggerAppenderFirephp.php
(original)
+++ logging/log4php/trunk/src/main/php/appenders/LoggerAppenderFirephp.php Mon
Mar 26 05:24:26 2012
@@ -66,7 +66,12 @@ class LoggerAppenderFirephp extends Logg
* @return void
*/
public function activateOptions() {
- $this->closed = false;
+ $console = $this->getConsole();
+ if (null === $console) {
+ $this->warn('FirePHP is not installed correctly.');
+ }
+
+ $this->closed = true;
}
/**
@@ -77,11 +82,6 @@ class LoggerAppenderFirephp extends Logg
* @return void
*/
public function append(LoggerLoggingEvent $event) {
- $console = $this->getConsole();
- if (null === $console) {
- $this->warn('FirePHP is not installed correctly.');
- }
-
$msg = $this->getLayout()->format($event);
switch ($this->getLogLevel($event)) {
