svn commit: r1305228 - /logging/log4php/trunk/src/main/php/appenders/LoggerAppenderFirephp.php

[floriansemm]

Author: floriansemm
Date: Mon Mar 26 05:27:41 2012
New Revision: 1305228

URL: http://svn.apache.org/viewvc?rev=1305228&view=rev
Log:
don't fail silently. move check for firephp-lib to activeOptions method

Modified:
    logging/log4php/trunk/src/main/php/appenders/LoggerAppenderFirephp.php

Modified: logging/log4php/trunk/src/main/php/appenders/LoggerAppenderFirephp.php
URL: 
http://svn.apache.org/viewvc/logging/log4php/trunk/src/main/php/appenders/LoggerAppenderFirephp.php?rev=1305228&r1=1305227&r2=1305228&view=diff
==============================================================================
--- logging/log4php/trunk/src/main/php/appenders/LoggerAppenderFirephp.php 
(original)
+++ logging/log4php/trunk/src/main/php/appenders/LoggerAppenderFirephp.php Mon 
Mar 26 05:27:41 2012
@@ -66,8 +66,8 @@ class LoggerAppenderFirephp extends Logg
         * @return void
         */
        public function activateOptions() {
-               $console = $this->getConsole();
-               if (null === $console) {
+               $this->console = $this->getConsole();
+               if (null === $this->console) {
                        $this->warn('FirePHP is not installed correctly.');
                }               
                
@@ -77,7 +77,7 @@ class LoggerAppenderFirephp extends Logg
        /**
         * Write event object to Log. Defaults to INFO level
         *
-        * @param LoggerLoggingEvent $event Includes level & message
+        * @param LoggerLoggingEvent this->consoleIncludes level & message
         *
         * @return void
         */
@@ -86,19 +86,19 @@ class LoggerAppenderFirephp extends Logg
                
                switch ($this->getLogLevel($event)) {
                case 'debug':
-                       $console->trace($msg);  //includes backtrace
+                       $this->console->trace($msg);    //includes backtrace
                        break;
                case 'warn':
-                       $console->debug($msg);
+                       $this->console->debug($msg);
                        break;
                case 'error':
-                       $console->warn($msg);
+                       $this->console->warn($msg);
                        break;
                case 'fatal':
-                       $console->error($msg);
+                       $this->console->error($msg);
                        break;
                default:
-                       $console->info($msg);
+                       $this->console->info($msg);
                }
        }