Repository: mesos
Updated Branches:
  refs/heads/master 253c2899b -> 0685b3ce3


Fixed clang build on e.g., ubuntu16.

The clang version on e.g., ubuntu16 would emit a diagnostic message
for the increment inside the expectation,

    ../../src/tests/log_tests.cpp:2439:120:           \
      error: expression with side effects has no effect

We reorder expressions to avoid above situation.

Review: https://reviews.apache.org/r/64810/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/0685b3ce
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/0685b3ce
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/0685b3ce

Branch: refs/heads/master
Commit: 0685b3ce3569ae79d620ea301b422c2c2814d3ea
Parents: 253c289
Author: Benjamin Bannier <benjamin.bann...@mesosphere.io>
Authored: Fri Dec 22 16:28:46 2017 +0100
Committer: Benjamin Bannier <bbann...@apache.org>
Committed: Fri Dec 22 16:28:46 2017 +0100

----------------------------------------------------------------------
 src/tests/log_tests.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/0685b3ce/src/tests/log_tests.cpp
----------------------------------------------------------------------
diff --git a/src/tests/log_tests.cpp b/src/tests/log_tests.cpp
index 5dcb693..7554a1e 100644
--- a/src/tests/log_tests.cpp
+++ b/src/tests/log_tests.cpp
@@ -2436,7 +2436,8 @@ TEST_F(LogTest, ReaderCatchup)
 
   uint64_t position = 1;
   foreach (const Log::Entry& entry, entries.get()) {
-    EXPECT_EQ(stringify(position++), entry.data);
+    EXPECT_EQ(stringify(position), entry.data);
+    ++position;
   }
 }
 

Reply via email to