This is an automated email from the ASF dual-hosted git repository.
bmahler pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
The following commit(s) were added to refs/heads/master by this push:
new 59d82a75a [cgroups2] Remove completed todos.
59d82a75a is described below
commit 59d82a75aa9f7b8f41cd26ca95147b26ccaf3e5f
Author: Jason Zhou <[email protected]>
AuthorDate: Fri Aug 23 12:49:24 2024 -0400
[cgroups2] Remove completed todos.
The Todos mention recovery support for the device manager, and to use
the device manager recover in the device controller process.
We have added checkpointing and recovery support in:
https://reviews.apache.org/r/75145
We also only use the device manager recovery in the cgroups2 isolator
instead of in the device controller, as implemented in:
https://reviews.apache.org/r/75149/
As such, these todos are considered completed, and can be removed.
Review: https://reviews.apache.org/r/75189/
---
src/slave/containerizer/device_manager/device_manager.hpp | 2 --
.../containerizer/mesos/isolators/cgroups2/controllers/devices.cpp | 1 -
2 files changed, 3 deletions(-)
diff --git a/src/slave/containerizer/device_manager/device_manager.hpp
b/src/slave/containerizer/device_manager/device_manager.hpp
index 0a8ea4f93..d10d33a66 100644
--- a/src/slave/containerizer/device_manager/device_manager.hpp
+++ b/src/slave/containerizer/device_manager/device_manager.hpp
@@ -45,8 +45,6 @@ class DeviceManagerProcess;
// the centralized device manager to manage the state and provide an interface
// to incrementally adjust the device access state for a cgroup and generate
// the appropriate ebpf programs.
-//
-// TODO(jasonzhou): Add checkpointing / recovery support in follow-on patches.
class DeviceManager
{
public:
diff --git
a/src/slave/containerizer/mesos/isolators/cgroups2/controllers/devices.cpp
b/src/slave/containerizer/mesos/isolators/cgroups2/controllers/devices.cpp
index 702ed50b0..a8cb0966e 100644
--- a/src/slave/containerizer/mesos/isolators/cgroups2/controllers/devices.cpp
+++ b/src/slave/containerizer/mesos/isolators/cgroups2/controllers/devices.cpp
@@ -155,7 +155,6 @@ Future<Nothing> DeviceControllerProcess::recover(
const ContainerID& containerId,
const string& cgroup)
{
- // TODO(jasonzhou): Work with device manager recovery.
if (containerIds.contains(containerId)) {
return Failure(
"The controller '" + name() + "' of container " +
