This is an automated email from the ASF dual-hosted git repository.
bmahler pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
The following commit(s) were added to refs/heads/master by this push:
new 175f09d38 [gpu] Let NvidiaGpuIsolatorProcess support nesting.
175f09d38 is described below
commit 175f09d38ecf97bd1fdff4b600fda031c4a8439a
Author: Jason Zhou <[email protected]>
AuthorDate: Fri Aug 23 12:50:10 2024 -0400
[gpu] Let NvidiaGpuIsolatorProcess support nesting.
The NvidiaGpuIsolatorProcess currently still does not declare itself
to support nesting because nested containers were not supported for
the cgroups2 isolator.
Nested container support was added for cgroups2 isolator in:
https://reviews.apache.org/r/75177/
As such we will declare NvidiaGpuIsolatorProcess to be good for nesting.
Review: https://reviews.apache.org/r/75190/
---
src/slave/containerizer/mesos/isolators/gpu/isolator.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/slave/containerizer/mesos/isolators/gpu/isolator.cpp
b/src/slave/containerizer/mesos/isolators/gpu/isolator.cpp
index 78c63510d..00a406ffc 100644
--- a/src/slave/containerizer/mesos/isolators/gpu/isolator.cpp
+++ b/src/slave/containerizer/mesos/isolators/gpu/isolator.cpp
@@ -285,8 +285,7 @@ Try<Isolator*> NvidiaGpuIsolatorProcess::create(
bool NvidiaGpuIsolatorProcess::supportsNesting()
{
- // TODO(jasonzhou): return true once nesting is supported w/cgroups v2.
- return usingCgroups2 ? false : true;
+ return true;
}