This is an automated email from the ASF dual-hosted git repository. sandreoli pushed a commit to branch review-bls in repository https://gitbox.apache.org/repos/asf/incubator-milagro-crypto-c.git
commit cc015202131b6e0e286559c6db7aa5c7e419fd5a Author: samuele-andreoli <[email protected]> AuthorDate: Wed Nov 13 16:21:43 2019 +0000 normalise secret for comparison in secret recover --- src/bls.c.in | 2 ++ src/bls192.c.in | 2 ++ src/bls256.c.in | 2 ++ 3 files changed, 6 insertions(+) diff --git a/src/bls.c.in b/src/bls.c.in index 009dabd..e9540c1 100644 --- a/src/bls.c.in +++ b/src/bls.c.in @@ -343,6 +343,8 @@ int BLS_ZZZ_RECOVER_SECRET(int k, octet* X, octet* Y, octet* SK) BIG_XXX_modmul(prod,y,coefs[i],r); BIG_XXX_add(secret, secret, prod); + // Normalise input for comp + BIG_XXX_norm(secret); if (BIG_XXX_comp(secret,r) == 1) { BIG_XXX_sub(secret,secret,r); diff --git a/src/bls192.c.in b/src/bls192.c.in index 97c631d..7e4a8af 100644 --- a/src/bls192.c.in +++ b/src/bls192.c.in @@ -344,6 +344,8 @@ int BLS_ZZZ_RECOVER_SECRET(int k, octet* X, octet* Y, octet* SK) BIG_XXX_modmul(prod,y,coefs[i],r); BIG_XXX_add(secret, secret, prod); + // Normalise input for comp + BIG_XXX_norm(secret); if (BIG_XXX_comp(secret,r) == 1) { BIG_XXX_sub(secret,secret,r); diff --git a/src/bls256.c.in b/src/bls256.c.in index f847b3f..215864e 100644 --- a/src/bls256.c.in +++ b/src/bls256.c.in @@ -344,6 +344,8 @@ int BLS_ZZZ_RECOVER_SECRET(int k, octet* X, octet* Y, octet* SK) BIG_XXX_modmul(prod,y,coefs[i],r); BIG_XXX_add(secret, secret, prod); + // Normalise input for comp + BIG_XXX_norm(secret); if (BIG_XXX_comp(secret,r) == 1) { BIG_XXX_sub(secret,secret,r);
