This is an automated email from the ASF dual-hosted git repository. sandreoli pushed a commit to branch review-bls in repository https://gitbox.apache.org/repos/asf/incubator-milagro-crypto-c.git
commit a4d9072a16f283910f3f441bd53effafa82d6e7b Author: samuele-andreoli <[email protected]> AuthorDate: Wed Nov 13 16:24:09 2019 +0000 remove unnecessary scalar multiplication API --- include/bls.h.in | 18 ------------------ include/bls192.h.in | 18 ------------------ include/bls256.h.in | 18 ------------------ src/bls.c.in | 40 ---------------------------------------- src/bls192.c.in | 40 ---------------------------------------- src/bls256.c.in | 40 ---------------------------------------- 6 files changed, 174 deletions(-) diff --git a/include/bls.h.in b/include/bls.h.in index ba79673..9f60451 100644 --- a/include/bls.h.in +++ b/include/bls.h.in @@ -91,24 +91,6 @@ int BLS_ZZZ_ADD_G1(octet *R1,octet *R2,octet *R); */ int BLS_ZZZ_ADD_G2(octet *W1,octet *W2,octet *W); -/** @brief Multiply a member group G1 by an integer - * - @param P integer - @param R member of G1 - @param T member of G1. T=P*R - @return Zero for success or else an error code - */ -int BLS_ZZZ_MUL_G1(octet *P,octet *R,octet *T); - -/** @brief Multiply a member group G2 by an integer - * - @param P integer - @param R member of G2 - @param T member of G2. T=P*R - @return Zero for success or else an error code - */ -int BLS_ZZZ_MUL_G2(octet *P,octet *R,octet *T); - /** @brief Use Shamir's secret sharing to distribute BLS secret keys * @param k Threshold diff --git a/include/bls192.h.in b/include/bls192.h.in index 143fcaf..f6c7fb1 100644 --- a/include/bls192.h.in +++ b/include/bls192.h.in @@ -91,24 +91,6 @@ int BLS_ZZZ_ADD_G1(octet *R1,octet *R2,octet *R); */ int BLS_ZZZ_ADD_G2(octet *W1,octet *W2,octet *W); -/** @brief Multiply a member group G1 by an integer - * - @param P integer - @param R member of G1 - @param T member of G1. T=P*R - @return Zero for success or else an error code - */ -int BLS_ZZZ_MUL_G1(octet *P,octet *R,octet *T); - -/** @brief Multiply a member group G2 by an integer - * - @param P integer - @param R member of G2 - @param T member of G2. T=P*R - @return Zero for success or else an error code - */ -int BLS_ZZZ_MUL_G2(octet *P,octet *R,octet *T); - /** @brief Use Shamir's secret sharing to distribute BLS secret keys * @param k Threshold diff --git a/include/bls256.h.in b/include/bls256.h.in index 87be447..4695fc6 100644 --- a/include/bls256.h.in +++ b/include/bls256.h.in @@ -91,24 +91,6 @@ int BLS_ZZZ_ADD_G1(octet *R1,octet *R2,octet *R); */ int BLS_ZZZ_ADD_G2(octet *W1,octet *W2,octet *W); -/** @brief Multiply a member group G1 by an integer - * - @param P integer - @param R member of G1 - @param T member of G1. T=P*R - @return Zero for success or else an error code - */ -int BLS_ZZZ_MUL_G1(octet *P,octet *R,octet *T); - -/** @brief Multiply a member group G2 by an integer - * - @param P integer - @param R member of G2 - @param T member of G2. T=P*R - @return Zero for success or else an error code - */ -int BLS_ZZZ_MUL_G2(octet *P,octet *R,octet *T); - /** @brief Use Shamir's secret sharing to distribute BLS secret keys * @param k Threshold diff --git a/src/bls.c.in b/src/bls.c.in index e9540c1..29ee66a 100644 --- a/src/bls.c.in +++ b/src/bls.c.in @@ -221,46 +221,6 @@ int BLS_ZZZ_ADD_G2(octet *W1,octet *W2,octet *W) return BLS_OK; } -/* T=P*R in group G1 */ -int BLS_ZZZ_MUL_G1(octet *P,octet *R,octet *T) -{ - BIG_XXX p; - ECP_ZZZ R1; - - P->len=MODBYTES_XXX; - BIG_XXX_fromBytes(p,P->val); - - if (!ECP_ZZZ_fromOctet(&R1,R)) - { - return BLS_INVALID_G1; - } - - PAIR_ZZZ_G1mul(&R1,p); - ECP_ZZZ_toOctet(T,&R1,true); - - return BLS_OK; -} - -/* T=P*R in group G2 */ -int BLS_ZZZ_MUL_G2(octet *P,octet *R,octet *T) -{ - BIG_XXX p; - ECP2_ZZZ R1; - - P->len=MODBYTES_XXX; - BIG_XXX_fromBytes(p,P->val); - - if (!ECP2_ZZZ_fromOctet(&R1,R)) - { - return BLS_INVALID_G2; - } - - PAIR_ZZZ_G2mul(&R1,p); - ECP2_ZZZ_toOctet(T,&R1); - - return BLS_OK; -} - int BLS_ZZZ_MAKE_SHARES(int k, int n, csprng *RNG, octet* X, octet* Y, octet* SKI, octet* SKO) { BIG_XXX r; diff --git a/src/bls192.c.in b/src/bls192.c.in index 7e4a8af..30fabb5 100644 --- a/src/bls192.c.in +++ b/src/bls192.c.in @@ -222,46 +222,6 @@ int BLS_ZZZ_ADD_G2(octet *W1,octet *W2,octet *W) return BLS_OK; } -/* T=P*R in group G1 */ -int BLS_ZZZ_MUL_G1(octet *P,octet *R,octet *T) -{ - BIG_XXX p; - ECP_ZZZ R1; - - P->len=MODBYTES_XXX; - BIG_XXX_fromBytes(p,P->val); - - if (!ECP_ZZZ_fromOctet(&R1,R)) - { - return BLS_INVALID_G1; - } - - PAIR_ZZZ_G1mul(&R1,p); - ECP_ZZZ_toOctet(T,&R1,true); - - return BLS_OK; -} - -/* T=P*R in group G2 */ -int BLS_ZZZ_MUL_G2(octet *P,octet *R,octet *T) -{ - BIG_XXX p; - ECP4_ZZZ R1; - - P->len=MODBYTES_XXX; - BIG_XXX_fromBytes(p,P->val); - - if (!ECP4_ZZZ_fromOctet(&R1,R)) - { - return BLS_INVALID_G2; - } - - PAIR_ZZZ_G2mul(&R1,p); - ECP4_ZZZ_toOctet(T,&R1); - - return BLS_OK; -} - int BLS_ZZZ_MAKE_SHARES(int k, int n, csprng *RNG, octet* X, octet* Y, octet* SKI, octet* SKO) { BIG_XXX r; diff --git a/src/bls256.c.in b/src/bls256.c.in index 215864e..fad2c9c 100644 --- a/src/bls256.c.in +++ b/src/bls256.c.in @@ -222,46 +222,6 @@ int BLS_ZZZ_ADD_G2(octet *W1,octet *W2,octet *W) return BLS_OK; } -/* T=P*R in group G1 */ -int BLS_ZZZ_MUL_G1(octet *P,octet *R,octet *T) -{ - BIG_XXX p; - ECP_ZZZ R1; - - P->len=MODBYTES_XXX; - BIG_XXX_fromBytes(p,P->val); - - if (!ECP_ZZZ_fromOctet(&R1,R)) - { - return BLS_INVALID_G1; - } - - PAIR_ZZZ_G1mul(&R1,p); - ECP_ZZZ_toOctet(T,&R1,true); - - return BLS_OK; -} - -/* T=P*R in group G2 */ -int BLS_ZZZ_MUL_G2(octet *P,octet *R,octet *T) -{ - BIG_XXX p; - ECP8_ZZZ R1; - - P->len=MODBYTES_XXX; - BIG_XXX_fromBytes(p,P->val); - - if (!ECP8_ZZZ_fromOctet(&R1,R)) - { - return BLS_INVALID_G2; - } - - PAIR_ZZZ_G2mul(&R1,p); - ECP8_ZZZ_toOctet(T,&R1); - - return BLS_OK; -} - int BLS_ZZZ_MAKE_SHARES(int k, int n, csprng *RNG, octet* X, octet* Y, octet* SKI, octet* SKO) { BIG_XXX r;
