kpuatamazon commented on a change in pull request #17559:
URL: https://github.com/apache/incubator-mxnet/pull/17559#discussion_r479327945
##########
File path: CMakeLists.txt
##########
@@ -474,6 +490,13 @@ endif()
FILE(GLOB_RECURSE SOURCE "src/*.cc" "src/*.h" "include/*.h")
FILE(GLOB_RECURSE CUDA "src/*.cu" "src/*.cuh")
+if (USE_INTGEMM)
+ list(APPEND SOURCE "3rdparty/intgemm/intgemm.cc")
+else()
+ FILE(GLOB_RECURSE INTGEMM_OPERATOR_SOURCE
"src/operator/contrib/intgemm/*.cc" "src/operator/contrib/intgemm/*.h")
+ list(REMOVE_ITEM SOURCE ${INTGEMM_OPERATOR_SOURCE})
+endif()
Review comment:
Think this was meant to be a comment on `add_subdirectory`? The minimal
build needs `intgemm.cc` compiled in and these compilation tests that generate
a header file:
https://github.com/kpu/intgemm/blob/0f05c3ebd037eacdf8cff165736fea2b0d125023/CMakeLists.txt#L20-L37
Not sure how to make `cmake` run the compilation tests without
`add_subdirectory`? I can do `add_subdirectory( 3rdparty/intgemm
EXCLUDE_FROM_ALL)` if that helps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
