kpuatamazon commented on a change in pull request #17559:
URL: https://github.com/apache/incubator-mxnet/pull/17559#discussion_r479412917
##########
File path: CMakeLists.txt
##########
@@ -474,6 +490,13 @@ endif()
FILE(GLOB_RECURSE SOURCE "src/*.cc" "src/*.h" "include/*.h")
FILE(GLOB_RECURSE CUDA "src/*.cu" "src/*.cuh")
+if (USE_INTGEMM)
+ list(APPEND SOURCE "3rdparty/intgemm/intgemm.cc")
+else()
+ FILE(GLOB_RECURSE INTGEMM_OPERATOR_SOURCE
"src/operator/contrib/intgemm/*.cc" "src/operator/contrib/intgemm/*.h")
+ list(REMOVE_ITEM SOURCE ${INTGEMM_OPERATOR_SOURCE})
+endif()
Review comment:
33ad78208c911a5e9d770416266b0d3510767213 now uses
`target_link_libraries(mxnet PRIVATE intgemm)`
Regarding `INTGEMM_OPERATOR_SOURCE`, that's not adding stuff, it's removing
the MXNet-side operator implementations (which were caught by the glob) if the
user elects to not compile support.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
