samskalicky commented on a change in pull request #19016:
URL: https://github.com/apache/incubator-mxnet/pull/19016#discussion_r479800765
##########
File path: src/initialize.cc
##########
@@ -97,9 +97,7 @@ LibraryInitializer::LibraryInitializer()
install_pthread_atfork_handlers();
}
-LibraryInitializer::~LibraryInitializer() {
- close_open_libs();
-}
+LibraryInitializer::~LibraryInitializer() = default;
Review comment:
We cant check if handles are closed while libmxnet.so is closing. It
would have to be checked elsewhere so the loaded libraries can live during
libmxnet.so shutdown. If we put in a check it will print out to the user every
time since the expectation is that the handles are closed after libmxnet.so
We're not talking about hundreds of handles, we're talking about one or
maybe two libraries loaded by the user explicitly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
