sxjscience commented on a change in pull request #19059:
URL: https://github.com/apache/incubator-mxnet/pull/19059#discussion_r500610032
##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -163,28 +149,27 @@ def test_all():
@use_np
def test_amin():
- A = np.ones((INT_OVERFLOW, 2))
- A[100][1] = -1
- A.attach_grad()
+ inp = np.ones((INT_OVERFLOW, 2))
+ inp[-1, -1] = -1
+ inp.attach_grad()
Review comment:
We may also later add the check about `req="add"`. But this can be done
in a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
