sxjscience commented on a change in pull request #19059:
URL: https://github.com/apache/incubator-mxnet/pull/19059#discussion_r500620523
##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -163,28 +149,27 @@ def test_all():
@use_np
def test_amin():
- A = np.ones((INT_OVERFLOW, 2))
- A[100][1] = -1
- A.attach_grad()
+ inp = np.ones((INT_OVERFLOW, 2))
+ inp[-1, -1] = -1
+ inp.attach_grad()
Review comment:
Basically, the test here is still not enough to ensure that it will work
in the DL system. We will need to test for 1) `req=add`, 2) backward other than
all ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
