sxjscience commented on a change in pull request #19302:
URL: https://github.com/apache/incubator-mxnet/pull/19302#discussion_r502651401
##########
File path: src/operator/numpy/np_matrix_op-inl.h
##########
@@ -1250,7 +1250,7 @@ void NumpyConcatenateBackward(const nnvm::NodeAttrs&
attrs,
}
struct NumpyDiagParam : public dmlc::Parameter<NumpyDiagParam> {
- int k;
+ index_t k;
Review comment:
I think `int k` should be good enough for most scenarios. There's no
need to use `index_t` for k.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
