leezu commented on a change in pull request #19174:
URL: https://github.com/apache/incubator-mxnet/pull/19174#discussion_r529017100



##########
File path: CMakeLists.txt
##########
@@ -444,19 +446,78 @@ elseif(UNIX)
   list(APPEND mxnet_LINKER_LIBS Threads::Threads)
 endif()
 
+if(BLAS STREQUAL "Open" OR BLAS STREQUAL "open")

Review comment:
       Can we keep this configuration in the ChooseBlas file? You can use 
PARENT_SCOPE option to modify the cmakelists scope variables: 
https://cmake.org/cmake/help/latest/command/set.html




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to