leezu commented on a change in pull request #19174:
URL: https://github.com/apache/incubator-mxnet/pull/19174#discussion_r529890035
##########
File path: ci/docker/Dockerfile.build.centos7
##########
@@ -70,6 +70,13 @@ RUN yum -y check-update || true && \
gcc-gfortran && \
yum clean all
+RUN mkdir ~/ninja && \
+ cd ~/ninja && \
+ wget
https://github.com/ninja-build/ninja/releases/download/v1.10.1/ninja-linux.zip
&& \
+ unzip ninja-linux.zip -d /usr/local/bin/ && \
+ alternatives --install /usr/bin/ninja ninja /usr/local/bin/ninja 1 && \
+ ninja --version
+
Review comment:
You're introducing a dependency on cmake 3.16 and ninja 10. Both are
available on Ubuntu 20.04 but not on 18.04. We can do it in principle, but it
would cause some trouble for users on older systems. I just want to make sure
you are conscious of that. Did you take a look at
https://github.com/scikit-build/cmake-FindFortran which Brad recommended?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
