josephevans commented on a change in pull request #19654:
URL: https://github.com/apache/incubator-mxnet/pull/19654#discussion_r540694584
##########
File path: ci/build.py
##########
@@ -117,6 +123,8 @@ def run_cmd():
image_id = _get_local_image_id(docker_tag=tag)
if not image_id:
raise FileNotFoundError('Unable to find docker image id matching with
{}'.format(tag))
+ # now that we've built the container, push it to our docker cache
+ push_docker_cache(registry, tag, image_id)
Review comment:
But the original point in having the push there is to have all slave
machines push up an image if they build it, so we don't rely on a scheduled job
to build and push these images up. With the "crowd sourced" method, the first
CI slave that has to build the container will push it up, and all immediate
future invocations using the same image will benefit immediately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
