josephevans commented on a change in pull request #19654:
URL: https://github.com/apache/incubator-mxnet/pull/19654#discussion_r541182635
##########
File path: ci/build.py
##########
@@ -117,6 +123,9 @@ def run_cmd():
image_id = _get_local_image_id(docker_tag=tag)
if not image_id:
raise FileNotFoundError('Unable to find docker image id matching with
{}'.format(tag))
+ # now that we've built the container, push it to our docker cache if
DOCKER_ECR_CACHE is defined
+ if 'DOCKER_ECR_REGISTRY' in os.environ:
+ push_docker_cache(registry, tag, image_id)
Review comment:
Contributors can already modify the dockerfile's content in a PR which
is immediately run, so having this false sense of security because only a
special job can publish containers to a private registry is nonsense.
In addition, docker will not push layers that already exists in the
registry, so the push essential becomes a no-op.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
