anko-intel commented on a change in pull request #20430:
URL: https://github.com/apache/incubator-mxnet/pull/20430#discussion_r674022121
##########
File path: src/operator/quantization/asymmetric_quantize_graph_pass.cc
##########
@@ -36,8 +36,7 @@ using nnvm::NodeEntry;
using nnvm::Graph;
template <bool require_bias>
-static inline bool IsOneDNNFullyConnected(const ObjectPtr& n) {
-#if MXNET_USE_MKLDNN == 1
+bool IsOneDNNFullyConnected(const ObjectPtr& n) {
Review comment:
Please do not remove "static". Otherwise not required function by other
modules will be visible outside this module. IT potentially could increase
linking time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
