sfraczek commented on a change in pull request #20349:
URL: https://github.com/apache/incubator-mxnet/pull/20349#discussion_r674736779
##########
File path: src/operator/nn/concat.cc
##########
@@ -166,18 +168,17 @@ bool ConcatType(const nnvm::NodeAttrs& attrs,
for (size_t i = 0; i < nin; ++i) {
in_type->push_back(dtype);
}
- // if out types are known in types are unknown
+ // if out types are known in types are unknown
Review comment:
I like this suggestion:
https://stackoverflow.com/a/64052524/5008804
but on the other hand it's troublesome to change them. maybe we should not
be so strict about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
