mozga-intel commented on a change in pull request #20349:
URL: https://github.com/apache/incubator-mxnet/pull/20349#discussion_r674887504
##########
File path: src/operator/nn/concat.cc
##########
@@ -166,18 +168,17 @@ bool ConcatType(const nnvm::NodeAttrs& attrs,
for (size_t i = 0; i < nin; ++i) {
in_type->push_back(dtype);
}
- // if out types are known in types are unknown
+ // if out types are known in types are unknown
Review comment:
Sounds good! I'm trying to check what could have been done to prevent
this situation. [Workaround] First of all, we can try to add additional space
between `if {} else {}` scope. However, It forces each of us to care about it ~
what sounds not bad, you are controlling what is going on! Secondly, a comment
might be placed directly in a line with a code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
