sandeep-krishnamurthy commented on a change in pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520#discussion_r688023527
##########
File path: LICENSE
##########
@@ -284,6 +284,22 @@
3rdparty/openmp
+
=======================================================================================
+ Apache-2.0 license + Microsoft Copyright
+
=======================================================================================
Review comment:
Thanks @leezu so I don't have to call these files out specially right as
it is Apache 2.0 licensed?
Also, since we have left copyright of MSFT in these files as is, I don't
have call it out in NOTICE file per the link you shared. let me know if this
accurate.
From https://infra.apache.org/licensing-howto.html#mod-notice
"Copyright notifications which have been relocated, rather than removed,
from source files must be preserved in NOTICE. However, elements such as the
copyright notifications embedded within BSD and MIT licenses do not need to be
duplicated in NOTICE. You can leave those notices in their original locations."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
