sandeep-krishnamurthy commented on pull request #20520: URL: https://github.com/apache/incubator-mxnet/pull/20520#issuecomment-897956987
@leezu >> Copyright notices shouldn't go to LICENSE AFAIK. At least it's not required and for consistency we may want to keep them out. WDYT? Agreed. They are Apache 2.0 license. Copyright need not come here in License file. >> Can you confirm that the reason for removing the ASF headers is that you think the files only contain minor modifications compared to the original Microsoft AL2 implementation? For major modifications, it's totally fine to add ASF header. https://www.apache.org/legal/src-headers.html#3party That is correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
