szha commented on a change in pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482#discussion_r702479766
##########
File path: src/operator/operator_common.h
##########
@@ -620,6 +620,10 @@ class OpSignature {
hash = hash * 2 + arr.dtype();
eles.push_back(arr.dtype());
AddSign(arr.shape());
+#if DNNL_AARCH64_USE_ACL == 1
+ auto ival = reinterpret_cast<const uint64_t>(arr.storage_handle().dptr);
+ AddSign(ival);
+#endif
Review comment:
I'm also trying to understand why the hash on pointer address is only
needed when building ARM64 with oneDNN. Assuming no hash collision, this
basically means no reusing, which I'm not sure is the right way to fix it.
What's the cause for the wrong reuse?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
