DickJC123 commented on a change in pull request #18683: URL: https://github.com/apache/incubator-mxnet/pull/18683#discussion_r708758413
########## File path: src/common/nvtx.h ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#ifndef MXNET_COMMON_NVTX_H_ +#define MXNET_COMMON_NVTX_H_ + +#if MXNET_USE_CUDA && MXNET_USE_NVTX +#include <cuda.h> +#include <cuda_runtime.h> +#include <nvToolsExtCuda.h> +#include <vector> +#include <string> +#include <cstring> + +namespace mxnet { +namespace common { +namespace cuda { + +class NVTXDuration { + public: + explicit NVTXDuration(const char *name) noexcept + : range_id_(0), name_(name) {} + + inline void start() { + range_id_ = nvtxRangeStartA(name_); + } + + inline void stop() { + nvtxRangeEnd(range_id_); + } + + private: + nvtxRangeId_t range_id_; + const char *name_; +}; + +// Utility class for NVTX +class nvtx { + public: + // Palette of colors (make sure to add new colors to the vector in nameToColor()). + static const uint32_t kRed = 0xFF0000; + static const uint32_t kGreen = 0x00FF00; + static const uint32_t kBlue = 0x0000FF; + static const uint32_t kYellow = 0xB58900; + static const uint32_t kOrange = 0xCB4B16; + static const uint32_t kRed1 = 0xDC322F; + static const uint32_t kMagenta = 0xD33682; + static const uint32_t kViolet = 0x6C71C4; + static const uint32_t kBlue1 = 0x268BD2; + static const uint32_t kCyan = 0x2AA198; + static const uint32_t kGreen1 = 0x859900; + + static void gpuRangeStart(const uint32_t rgb, const std::string& range_name) { Review comment: In threaded engine, the following does a copy that could be avoided if everything was handled as a `const char *`: ``` auto nvtx_name = opr_block->opr->opr_name != "" ? opr_block->opr->opr_name : "Op"; ``` so perhaps like: ``` auto nvtx_name = opr_block->opr->opr_name.size() ? opr_block->opr->opr_name.c_str() : "Op"; ``` It's a nit as I say, so I'm OK leaving it as: `const std::string& range_name`. Given that though, the two overloaded nameToColor() signatures should be consistent in their use of std::string (see an additional suggestion). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
