DickJC123 commented on a change in pull request #18683: URL: https://github.com/apache/incubator-mxnet/pull/18683#discussion_r713252701
########## File path: python/mxnet/cuda_utils.py ########## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Provides python interface to cuda-related functions of the mxnet library.""" +from .base import _LIB, mx_uint, c_str, check_call + +def nvtx_range_push(name, color=13323030): Review comment: Couple of new comments. First, I somehow miscopied the enums in my suggestion above. The second 'RED' should be 'RED1' to mirror what's in nvtx.h. Second, the colors set up in the backend are currently only used to assign colors by default based on a hash of the range name. Perhaps you'd consider exposing this the same way to Python? So for example, ``` def nvtx_range_push(name, color=None): # if color is None, then assign a color based on a hash of name ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
