bartekkuncer commented on a change in pull request #20606:
URL: https://github.com/apache/incubator-mxnet/pull/20606#discussion_r724248287
##########
File path: src/operator/subgraph/dnnl/dnnl_conv.cc
##########
@@ -686,23 +682,22 @@ static bool SgMKLDNNConvOpStorageType(const
nnvm::NodeAttrs& attrs,
}
}
-std::vector<std::pair<int, int>> SgMKLDNNConvInplaceOption(const NodeAttrs&
attrs) {
- auto const& param = nnvm::get<MKLDNNConvFusionParam>(attrs.parsed);
- if (param.full_conv_param.mkldnn_param.with_sum &&
- !param.full_conv_param.mkldnn_param.dedup_sum) {
+std::vector<std::pair<int, int>> SgDNNLConvInplaceOption(const NodeAttrs&
attrs) {
+ auto const& param = nnvm::get<DNNLConvFusionParam>(attrs.parsed);
+ if (param.full_conv_param.dnnl_param.with_sum &&
!param.full_conv_param.dnnl_param.dedup_sum) {
return std::vector<std::pair<int, int>>{{GetInSumIndex(param), 0}};
} else {
return std::vector<std::pair<int, int>>();
}
}
-nnvm::ObjectPtr SgMKLDNNConvQuantizedOp(const NodeAttrs& attrs) {
- auto const& param = nnvm::get<MKLDNNConvFusionParam>(attrs.parsed);
+nnvm::ObjectPtr SgDNNLConvQuantizedOp(const NodeAttrs& attrs) {
+ auto const& param = nnvm::get<DNNLConvFusionParam>(attrs.parsed);
nnvm::ObjectPtr node = nnvm::Node::Create();
- node->attrs.op = Op::Get("_sg_mkldnn_conv");
+ node->attrs.op = Op::Get("_sg_dnnl_conv");
const int k_ndims = param.full_conv_param.conv_param.kernel.ndim();
CHECK(k_ndims == 2U || k_ndims == 3U)
- << "Quantized Convolution of MKL-DNN supports 2D/3D kernel currently."
+ << "Quantized Convolution of DNNL supports 2D/3D kernel currently."
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
