bartekkuncer commented on a change in pull request #20606:
URL: https://github.com/apache/incubator-mxnet/pull/20606#discussion_r724248783
##########
File path: src/operator/subgraph/dnnl/dnnl_conv_property.h
##########
@@ -170,25 +165,25 @@ class SgMKLDNNConvSelector : public SubgraphSelector {
void Reset() override {
CHECK_GE(matched_list_.size(), 1);
- auto new_selector = SgMKLDNNConvSelector(
+ auto new_selector = SgDNNLConvSelector(
disable_all_, disable_conv_bn_, disable_conv_act_, disable_conv_sum_,
quantize_);
new_selector.Select(*matched_list_[0], nullptr);
*this = new_selector;
}
};
-class SgMKLDNNConvProperty : public SubgraphProperty {
+class SgDNNLConvProperty : public SubgraphProperty {
public:
- SgMKLDNNConvProperty() {
+ SgDNNLConvProperty() {
disable_conv_bn_ = dmlc::GetEnv("MXNET_DISABLE_ONEDNN_FUSE_CONV_BN", 0);
disable_conv_act_ = dmlc::GetEnv("MXNET_DISABLE_ONEDNN_FUSE_CONV_RELU", 0);
disable_conv_sum_ = dmlc::GetEnv("MXNET_DISABLE_ONEDNN_FUSE_CONV_SUM", 0);
disable_all_ = disable_conv_bn_ && disable_conv_act_ && disable_conv_sum_;
}
static SubgraphPropertyPtr Create() {
- static const std::string& name = "MKLDNN convolution optimization pass";
- auto property = std::make_shared<SgMKLDNNConvProperty>();
+ static const std::string& name = "DNNL convolution optimization pass";
Review comment:
done
##########
File path: src/operator/subgraph/dnnl/dnnl_conv_property.h
##########
@@ -204,7 +199,7 @@ class SgMKLDNNConvProperty : public SubgraphProperty {
nnvm::Symbol new_sym;
new_sym.outputs.emplace_back(last_node);
std::ostringstream node_name;
- node_name << "sg_mkldnn_";
+ node_name << "sg_dnnl_";
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
