leezu commented on a change in pull request #20474:
URL: https://github.com/apache/incubator-mxnet/pull/20474#discussion_r725212081
##########
File path: cmake/upstream/FindBLAS.cmake
##########
@@ -522,12 +525,16 @@ if(BLA_VENDOR MATCHES "Intel" OR BLA_VENDOR STREQUAL
"All")
get_filename_component(BLAS_mkl_MKLROOT "${BLAS_mkl_MKLROOT}"
DIRECTORY)
endif()
endif()
+ # MXNET NOTE: This change comes form the newest file version
+ # https://gitlab.kitware.com/cmake/cmake/-/issues/22295
Review comment:
Do you mean you backported this change to our file? Or is our file now
up-to-date with upstream again? If it's the latter, you don't need to add the
note here. If it's the former, why not update to the latest upstream instead of
backporting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
