akarbown commented on a change in pull request #20474:
URL: https://github.com/apache/incubator-mxnet/pull/20474#discussion_r725240417
##########
File path: tools/staticbuild/build_lib.sh
##########
@@ -36,13 +40,18 @@ cmake -GNinja -C $cmake_config \
-DCMAKE_OSX_DEPLOYMENT_TARGET=10.13 \
..
ninja
+if [[ ! $PLATFORM == 'darwin' ]] && [[ $BLAS == 'mkl' ]]; then
+ patchelf --set-rpath
"/opt/intel/oneapi/mkl/${INTEL_MKL}/lib/intel64/:\$ORIGIN" --force-rpath
libmxnet.so
Review comment:
_> Will oneapi/mkl always be in /opt/intel?_
I think that if the user do not define explicitly other location, the
default location for oneMKL supposed to be /opt/intel/oneapi/ at least the way
it was installed in the way as it is in the mkl.sh file.
_> Is there a reason for not asking users to fix their run-time search path
environment variables instead (which ideally would automatically be set
correctly upon installation of oneapi/mkl)?_
I've added it for the sake of the tests so that while running them (in the
runtime) libmxnet.dylib could see the MKL libraries. It's not the best
solution. Now, I think that maybe it would be better to ``source
/opt/intel/oneapi/setvars.sh`` script just before the test execution (in the
*.yml file). What do you think? Or did you have someting else in mind?
##########
File path: tools/staticbuild/build_lib.sh
##########
@@ -36,13 +40,18 @@ cmake -GNinja -C $cmake_config \
-DCMAKE_OSX_DEPLOYMENT_TARGET=10.13 \
..
ninja
+if [[ ! $PLATFORM == 'darwin' ]] && [[ $BLAS == 'mkl' ]]; then
+ patchelf --set-rpath
"/opt/intel/oneapi/mkl/${INTEL_MKL}/lib/intel64/:\$ORIGIN" --force-rpath
libmxnet.so
Review comment:
_> Will oneapi/mkl always be in /opt/intel?_
I think that if the user do not define explicitly other location, the
default location for oneMKL supposed to be /opt/intel/oneapi/ at least the way
it was installed in the way as it is in the mkl.sh file.
_> Is there a reason for not asking users to fix their run-time search path
environment variables instead (which ideally would automatically be set
correctly upon installation of oneapi/mkl)?_
I've added it for the sake of the tests so that while running them (in the
runtime) libmxnet.dylib could see the MKL libraries. It's not the best
solution. Now, I think that maybe it would be better to ``source
/opt/intel/oneapi/setvars.sh`` script just before the test execution (in the
*.yml file). What do you think? Or did you have something else in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
