sergeykolychev commented on a change in pull request #20852:
URL: https://github.com/apache/incubator-mxnet/pull/20852#discussion_r793919904
##########
File path: perl-package/AI-MXNet/lib/AI/MXNet/Metric.pm
##########
@@ -79,7 +79,7 @@ use overload '""' => sub {
has 'name' => (is => 'rw', isa => 'Str');
has 'num' => (is => 'rw', isa => 'Int');
has 'num_inst' => (is => 'rw', isa => 'Maybe[Int|ArrayRef[Int]]');
-has 'sum_metric' => (is => 'rw', isa => 'Maybe[Num|ArrayRef[Num]]');
+has 'sum_metric' => (is => 'rw', isa => 'Maybe[Num|ArrayRef[Num]|PDL]');
Review comment:
Why is this needed ? Is $pdl->sum (and other similar methods) produce
pdl object now ? This change is a bit radical and will require additional tests
to see of something that is not covered by the CI is not broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
