anko-intel commented on code in PR #21002:
URL: https://github.com/apache/incubator-mxnet/pull/21002#discussion_r918911666
##########
src/common/utils.h:
##########
@@ -929,11 +929,8 @@ inline mxnet::TShape CanonicalizeAxes(const mxnet::TShape&
src) {
}
inline bool is_float(const int dtype) {
Review Comment:
maybe we can change the name to is_floating to emphase that it is not an
answer for particular type like float but common floating point group of data
representation
```suggestion
inline bool is_floating(const int dtype) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
