bgawrych commented on code in PR #21002:
URL: https://github.com/apache/incubator-mxnet/pull/21002#discussion_r921936320


##########
3rdparty/mshadow/mshadow/base.h:
##########
@@ -409,7 +409,7 @@ struct DataType<half::half_t> {
 #endif
 #endif
 };
-template<>
+template <>

Review Comment:
   can be done in other PR to keep this one simple to track relevant changes



##########
src/common/utils.h:
##########
@@ -929,11 +929,8 @@ inline mxnet::TShape CanonicalizeAxes(const mxnet::TShape& 
src) {
 }
 
 inline bool is_float(const int dtype) {

Review Comment:
   can be done in other PR to keep this one simple to track relevant changes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to