agrabows commented on code in PR #21115:
URL: https://github.com/apache/incubator-mxnet/pull/21115#discussion_r942624219


##########
src/operator/subgraph/dnnl/dnnl_transformer.cc:
##########
@@ -195,24 +233,28 @@ static bool SgDNNLSelfAttStorageType(const 
nnvm::NodeAttrs& attrs,
   return DNNLStorageType(attrs, dev_mask, true, dispatch_mode, in_attrs, 
out_attrs);
 }
 
+template <qk_common::mode qk_mode>
 void SgDNNLSelfAttQKOp::Initialize(const OpContext& ctx,
                                    const std::vector<NDArray>& inputs,
                                    const std::vector<OpReqType>& req,
                                    const std::vector<NDArray>& outputs) {
   using namespace dnnl;
 
-  const auto qkv_tensor = inputs[0];
-  const auto out_tensor = outputs[0];
+  const auto input_tensor = inputs[0];
+  const auto out_tensor   = outputs[0];
 
-  const auto qkv_dtype = get_dnnl_type(qkv_tensor.dtype());
+  const auto qkv_dtype = get_dnnl_type(input_tensor.dtype());
 
   const memory::dim heads          = param_.heads;
   const memory::dim sequences      = inputs[0].shape()[0];
   const memory::dim qkv_seq_len    = inputs[0].shape()[1];
   const memory::dim output_lin_dim = inputs[0].shape()[2];

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to