piiswrong commented on a change in pull request #7082: Sparse Tensor: request
for reviews
URL: https://github.com/apache/incubator-mxnet/pull/7082#discussion_r130272450
##########
File path: python/mxnet/optimizer.py
##########
@@ -342,17 +342,20 @@ def create_state(self, index, weight):
momentum = None
weight_master_copy = None
if self.multi_precision and weight.dtype == numpy.float16:
+ assert(weight.stype == 'default'), \
Review comment:
why not? why would happen for the other optimizers?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
