piiswrong commented on a change in pull request #7082: Sparse Tensor: request
for reviews
URL: https://github.com/apache/incubator-mxnet/pull/7082#discussion_r130257348
##########
File path: include/mxnet/kvstore.h
##########
@@ -155,6 +156,29 @@ class KVStore {
const std::vector<NDArray*>& values,
int priority = 0) = 0;
+ /*!
+ * \brief pull a list of key-value pairs from the store.
+ * The NDArray pulled back will be in row_sparse storage with only the
+ * specified row_ids present (others rows are zeros).
+ * \param keys the list of keys
+ * \param values the list of buffers - row_id pairs
+ * \param priority the priority of the action.
+ */
+ virtual void PullRowSparse(const std::vector<int>& str_keys,
+ const std::vector<std::pair<NDArray*, NDArray>>&
val_rowids,
Review comment:
why NDArray* to NDArray pairs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
