piiswrong commented on a change in pull request #7654: Making mixed precision 
work with all optimizers
URL: https://github.com/apache/incubator-mxnet/pull/7654#discussion_r140910850
 
 

 ##########
 File path: python/mxnet/optimizer.py
 ##########
 @@ -173,6 +182,36 @@ def create_state(self, index, weight):
             The state associated with the weight.
         """
 
+    def create_mp_state(self, index, weight):
+        """Creates auxiliary state for a given weight, including FP32 master
 
 Review comment:
   including FP32 master copy if necessary.
   ->
   including fp32 high precision copy if original weight is fp16
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to