piiswrong commented on a change in pull request #7654: Making mixed precision
work with all optimizers
URL: https://github.com/apache/incubator-mxnet/pull/7654#discussion_r140911302
##########
File path: python/mxnet/optimizer.py
##########
@@ -379,7 +444,10 @@ def create_state(self, index, weight):
momentum = zeros(weight.shape, weight.context, dtype=weight.dtype,
stype=weight.stype)
return momentum
- def update(self, index, weight, grad, state):
+ def create_state(self, index, weight):
Review comment:
There should be a _create_state_impl function that both create_mp_state and
create_state use. And create_state should keep the original behavior (always
multi_precision=False)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
