eric-haibin-lin commented on a change in pull request #7947: [WIP] Refactor
infer storage function for sparse operators.
URL: https://github.com/apache/incubator-mxnet/pull/7947#discussion_r140922070
##########
File path: src/operator/operator_common.h
##########
@@ -253,6 +284,48 @@ inline bool type_assign(int *y, const int& x) {
}
#endif
+/*! \brief assign stype to target_stype, if successful,
+ * assign dispatch_mode to target_dispatch
+ */
+inline bool dispatch_on_storage(int* stype,
Review comment:
It also tries to assign dispatch_mode when stype assign is successful. The
behaviour is a bit different from type_assign and shape_assign. I named it
differently to avoid confusion. Does taht make sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services