eric-haibin-lin commented on a change in pull request #7947: [WIP] Refactor
infer storage function for sparse operators.
URL: https://github.com/apache/incubator-mxnet/pull/7947#discussion_r140922957
##########
File path: src/operator/optimizer_op-inl.h
##########
@@ -165,69 +165,6 @@ inline void SGDUpdateDnsRspImpl(const SGDParam& param,
});
}
-/*! \brief kernel for sparse sgd
- */
-template<int req>
-struct SGDRspDnsKernel {
Review comment:
To behave consistently with what's stated on doc, only perform sparse
updates for `sgd(row_sparse_weight, row_sparse_grad)` for now. Otherwise, we
also need to handle sparse weights with dense grads for Adam, Ftrl, etc. The
number of cases is too large
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
