stu1130 commented on a change in pull request #16335: [Numpy] Global numpy
shape flag
URL: https://github.com/apache/incubator-mxnet/pull/16335#discussion_r332642069
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -1524,12 +1524,15 @@ nightly_scala_demo_test_cpu() {
bash bin/run_im.sh
}
-nightly_estimator() {
+nightly_estimator_numpy_global_flag() {
Review comment:
The feature is only going to be used in MXNet subproject (even numpy willl
not use), so I think it makes sense to put in nightly test.
I changed the tests/nightly/JenkinsfileForBinaries to reference this
function. Do I still miss something?
The test should only be run alone, since it affect the behavior of numpy
shape in other tests that is run parallelly. i.e. It will crash our operator
unit test if I put this in noraml unit test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
