stu1130 commented on a change in pull request #16335: [Numpy] Global numpy
shape flag
URL: https://github.com/apache/incubator-mxnet/pull/16335#discussion_r332662015
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -1524,12 +1524,15 @@ nightly_scala_demo_test_cpu() {
bash bin/run_im.sh
}
-nightly_estimator() {
+nightly_estimator_numpy_global_flag() {
Review comment:
The project is not open source yet.
AFAIK, nosetest run tests in parallel. Currently numpy shape is claimed as
thread_local variable, this feature enable global functionaility where we can
see the flag from any thread. It means we might break non-numpy-compatible
operator test that is run parallelly because MXNet engine treat them as
numpy-compatible.
Although the payload is small, I don't want MXNet developers bothered by
this test and it's actually more like an integration test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
